-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] prerender shells when ssr false and prerender not false #8131
Conversation
🦋 Changeset detectedLatest commit: 513fd1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
get_option(nodes, 'ssr') === false && | ||
!leaf_node.server?.actions | ||
) { | ||
return await render_response({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated to code a little further below, but this way it's more readable (you don't need to hold all these conditions in your head until you arrive at the other condition)
Ha, this uncovered an unrelated bug in |
Closes #3966
This is a breaking change insofar that pages that have
export const ssr = false
and not explicitly setexport const prerender = false
orprerender.entries: []
will have theirhandle
hooks run, which could be unexpected and cause unintended side effects. In that's the case for you, addexport const prerender = false
next to wherever you haveexport const ssr = false
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0