Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] move writeBundle and closeBundle to compile plugin #8138

Merged
merged 1 commit into from
Dec 13, 2022
Merged

[chore] move writeBundle and closeBundle to compile plugin #8138

merged 1 commit into from
Dec 13, 2022

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Dec 13, 2022 •
edited
Loading

these are really more about compiling than setup. It also fixes Storybook build (the original version only worked with dev as I hadn't tested against build)

closes #5397

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022

⚠️ No Changeset found

Latest commit: da75158

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JReinhold JReinhold mentioned this pull request Dec 13, 2022
Merged
Rich-Harris
Rich-Harris approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taking your word for it 😆

@benmccann benmccann merged commit 78bdf60 into master Dec 13, 2022
@benmccann benmccann deleted the method-locations branch December 13, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storybook support
2 participants
@benmccann @Rich-Harris