Always return something from render
#847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #763 in two ways:
render
function inhandle
always returns aPromise<Response>
, which means the developer no longer has to handle the case where nothing is returned because we tried to prerender a non-prerenderable page (in which case we now get a204
).dependencies
object that used to accompany page responses now lives on theoptions
that are passed in toapp.render
, bypassing the developer entirely. This eliminates a potential class of bugs arising from someone selectively returning properties of the response inhandle
.Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
Changesets
pnpx changeset
and following the prompts