Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return something from render #847

Merged
merged 5 commits into from
Apr 3, 2021
Merged

Always return something from render #847

merged 5 commits into from
Apr 3, 2021

Conversation

Rich-Harris
Copy link
Member

This fixes #763 in two ways:

  1. The render function in handle always returns a Promise<Response>, which means the developer no longer has to handle the case where nothing is returned because we tried to prerender a non-prerenderable page (in which case we now get a 204).
  2. The dependencies object that used to accompany page responses now lives on the options that are passed in to app.render, bypassing the developer entirely. This eliminates a potential class of bugs arising from someone selectively returning properties of the response in handle.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris Rich-Harris merged commit 108c26c into master Apr 3, 2021
@Rich-Harris Rich-Harris deleted the gh-763 branch April 3, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hooks.js example causes a build error
1 participant