Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deploy server assets #9073

Merged
merged 3 commits into from
Feb 16, 2023
Merged

fix: deploy server assets #9073

merged 3 commits into from
Feb 16, 2023

Conversation

benmccann
Copy link
Member

closes #5240

@dummdidumm
Copy link
Member

Since you said this is Vite 4.1 related - is this backwards compatible?

@Conduitry
Copy link
Member

We've had a note in the past indicating that a given release only fixed a bug if you are using Vite 4.1+, which I think is a fine thing to do, but we should mention that in the changeset if that's the case.

We should also make sure that this doesn't actually break anything for people still on Vite 4.0. That will probably be a manual process, because we don't currently have a good way to do that in CI.

@benmccann
Copy link
Member Author

Yes, the changeset does mention Vite 4.1

I upgraded Vite to 4.1 in this PR in order to get the type for the ssrEmitAssets option as it would complain about an unknown option otherwise. But I reverted the last commit locally and ran the tests against Vite 4.0 and they all passed still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets are not included for the server (adapter-node)
4 participants