feat: editor support for ts 5.4 (#2334)

Follow up to #2313. The auto-import problem is fixed in 5.4.5.
sveltejs · Apr 16, 2024 · 4c8c0db · 4c8c0db
1 parent 4cf8410
commit 4c8c0db
Show file tree

Hide file tree

Showing 10 changed files with 40 additions and 41 deletions.
diff --git a/package.json b/package.json
@@ -13,7 +13,7 @@
         "lint": "prettier --check ."
     },
     "dependencies": {
-        "typescript": "^5.3.2"
+        "typescript": "^5.4.5"
     },
     "devDependencies": {
         "cross-env": "^7.0.2",

diff --git a/packages/language-server/package.json b/packages/language-server/package.json
@@ -57,7 +57,7 @@
         "svelte": "^3.57.0",
         "svelte-preprocess": "^5.1.3",
         "svelte2tsx": "workspace:~",
-        "typescript": "~5.3.2",
+        "typescript": "^5.3.2",
         "typescript-auto-import-cache": "^0.3.2",
         "vscode-css-languageservice": "~6.2.10",
         "vscode-html-languageservice": "~5.1.1",

diff --git a/packages/language-server/src/plugins/typescript/module-loader.ts b/packages/language-server/src/plugins/typescript/module-loader.ts
@@ -107,7 +107,6 @@ class ImpliedNodeFormatResolver {
         let mode = undefined;
         if (sourceFile) {
             this.cacheImpliedNodeFormat(sourceFile, compilerOptions);
-            // @ts-expect-error remove when bumping to TS 5.4
             mode = ts.getModeForResolutionAtIndex(sourceFile, importIdxInFile, compilerOptions);
         }
         return mode;

diff --git a/...ver/test/plugins/typescript/features/diagnostics/fixtures/style-directive/expectedv2.json b/...ver/test/plugins/typescript/features/diagnostics/fixtures/style-directive/expectedv2.json
@@ -6,7 +6,7 @@
         },
         "severity": 1,
         "source": "ts",
-        "message": "Argument of type 'boolean' is not assignable to parameter of type 'String | Number | null | undefined'.",
+        "message": "Argument of type 'true' is not assignable to parameter of type 'String | Number | null | undefined'.",
         "code": 2345,
         "tags": []
     },
@@ -17,7 +17,7 @@
         },
         "severity": 1,
         "source": "ts",
-        "message": "Argument of type 'boolean' is not assignable to parameter of type 'String | Number | null | undefined'.",
+        "message": "Argument of type 'true' is not assignable to parameter of type 'String | Number | null | undefined'.",
         "code": 2345,
         "tags": []
     }

diff --git a/...er/test/plugins/typescript/features/inlayHints/fixtures/component-handler/expectedv2.json b/...er/test/plugins/typescript/features/inlayHints/fixtures/component-handler/expectedv2.json
@@ -12,8 +12,8 @@
                 "value": "MouseEvent",
                 "location": {
                     "range": {
-                        "start": { "line": 15586, "character": 10 },
-                        "end": { "line": 15586, "character": 20 }
+                        "start": { "line": 15692, "character": 10 },
+                        "end": { "line": 15692, "character": 20 }
                     },
                     "uri": "<node_modules>/typescript/lib/lib.dom.d.ts"
                 }

diff --git a/...rver/test/plugins/typescript/features/inlayHints/fixtures/element-handler/expectedv2.json b/...rver/test/plugins/typescript/features/inlayHints/fixtures/element-handler/expectedv2.json
@@ -6,8 +6,8 @@
                 "value": "MouseEvent",
                 "location": {
                     "range": {
-                        "start": { "line": 15586, "character": 10 },
-                        "end": { "line": 15586, "character": 20 }
+                        "start": { "line": 15692, "character": 10 },
+                        "end": { "line": 15692, "character": 20 }
                     },
                     "uri": "<node_modules>/typescript/lib/lib.dom.d.ts"
                 }
@@ -21,8 +21,8 @@
                 "value": "EventTarget",
                 "location": {
                     "range": {
-                        "start": { "line": 8192, "character": 10 },
-                        "end": { "line": 8192, "character": 21 }
+                        "start": { "line": 8237, "character": 10 },
+                        "end": { "line": 8237, "character": 21 }
                     },
                     "uri": "<node_modules>/typescript/lib/lib.dom.d.ts"
                 }
@@ -32,8 +32,8 @@
                 "value": "HTMLButtonElement",
                 "location": {
                     "range": {
-                        "start": { "line": 9684, "character": 10 },
-                        "end": { "line": 9684, "character": 27 }
+                        "start": { "line": 9732, "character": 10 },
+                        "end": { "line": 9732, "character": 27 }
                     },
                     "uri": "<node_modules>/typescript/lib/lib.dom.d.ts"
                 }

diff --git a/packages/svelte-vscode/package.json b/packages/svelte-vscode/package.json
@@ -719,7 +719,7 @@
         "@types/vscode": "^1.67",
         "js-yaml": "^3.14.0",
         "tslib": "^2.4.0",
-        "typescript": "~5.3.2",
+        "typescript": "^5.4.5",
         "vscode-tmgrammar-test": "^0.0.11"
     },
     "dependencies": {

diff --git a/packages/svelte2tsx/package.json b/packages/svelte2tsx/package.json
@@ -40,7 +40,7 @@
         "svelte": "~3.57.0",
         "tiny-glob": "^0.2.6",
         "tslib": "^2.4.0",
-        "typescript": "^5.3.2"
+        "typescript": "^5.4.5"
     },
     "peerDependencies": {
         "svelte": "^3.55 || ^4.0.0-next.0 || ^4.0 || ^5.0.0-next.0",

diff --git a/packages/typescript-plugin/package.json b/packages/typescript-plugin/package.json
@@ -19,7 +19,7 @@
     "license": "MIT",
     "devDependencies": {
         "@types/node": "^16.0.0",
-        "typescript": "^5.3.2"
+        "typescript": "^5.4.5"
     },
     "dependencies": {
         "@jridgewell/sourcemap-codec": "^1.4.14",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml