(fix) treat unknown events on element with action as custom events #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Svelte is very dynamic in its nature. One feature is to add actions to DOM elements which in turn means additional events could be dispatched on that element. For the default namespace, transform unknown events on an element with an action so that they are treated as custom events. sveltejs#431
|
I just realized this would break people who enhanced the definition with their own, because we don't know of those and would still transform to the |
|
Actions can now be typed in various ways; closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Svelte is very dynamic in its nature. One feature is to add actions to DOM elements which in turn means additional events could be dispatched on that element. For the default namespace, transform unknown events on an element with an action so that they are treated as custom events.
#431