feat: reference/implementation codelens #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
pushed a commit
that referenced
this pull request
May 29, 2024
#2353 The reason is that VSCode requested document symbols twice for the outline view and the sticky scroll. We cancelled one of them so the outline view shows "no symbols found in document 'A.svelte'". It seems the VSCode ts extension also caches the result from tsserver, mostly because it'll also be used in code lens. But the result is mostly fast enough. A 5000-line file takes like 100ms so we probably don't need it now. We can probably reconsider if #2378 lands and see if there is a large performance regression.
|
Impressive! Out of curiousity: Do you have any idea why TS doesn't provide the code lens feature through its language service API? Is this something we should request to be added? |
|
No idea why, I guess they just thought it was simple enough and could be achieved with existing API. |
dummdidumm
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2130 Porting VSCode's implementation/reference code lens. This is not enabled by default. To enable this, you'll need to enable the
typescript.implementationsCodeLens.enabledconfig or thetypescript.referencesCodeLens.enabledconfig forlang="ts"andjavascript.referencesCodeLens.enabledfor js components. Note that we reuse config for ts/js files so it'll also enable the feature in ts/js files.For non-VSCode users
Due to protocol limitations, this feature only partly works on other LSP clients. A client middleware is required to map reference info to references UI. So LSP client author might need to add support for it. For neovim-lsp users, you'll need a similar solution for the typescript language server.
Screenshots
(Yes. this will work for Svelte 5 props if it's a separate interface)