Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't debounce document symbol request #2382

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: don't debounce document symbol request #2382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/language-server/src/plugins/PluginHost.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,12 +279,18 @@ export class PluginHost implements LSProvider, OnWatchFileChanges {
): Promise<SymbolInformation[]> {
const document = this.getDocument(textDocument.uri);

// VSCode requested document symbols twice for the outline view and the sticky scroll
// Manually delay here and don't use low priority as one of them will return no symbols
await new Promise((resolve) => setTimeout(resolve, 1000));
if (cancellationToken.isCancellationRequested) {
return [];
}
return flatten(
await this.execute<SymbolInformation[]>(
'getDocumentSymbols',
[document, cancellationToken],
ExecuteMode.Collect,
'low'
'high'
)
);
}
Expand Down
Loading