fix: correctly position quick fixes in instance and module #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
reviewed
Oct 10, 2024
packages/language-server/src/plugins/svelte/features/getCodeActions/getQuickfixes.ts
Outdated
Show resolved
Hide resolved
…tions/getQuickfixes.ts Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
dummdidumm
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a shot at closing #2529
some tests seems to be failing but they also seems to be unrelated to the change but maybe i'm wrong. Also, i need some guidance on where and how to write new tests here 🫨
I also have a problem with indentation because the indent seems to be always an empty string...i tried logging the
afterStartLineStartand it seems to consider all the content on a single lnie despite having some\nin it