fix: do not force slots to be self-closed (#435)

Related to sveltejs/kit#12102
sveltejs · Apr 12, 2024 · 539169b · 539169b
1 parent 601ee41
commit 539169b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/print/index.ts b/src/print/index.ts
@@ -215,10 +215,10 @@ export function print(path: FastPath, options: ParserOptions, print: PrintFn): D
                 ((((node.type === 'Element' && !options.svelteStrictMode) ||
                     node.type === 'Head' ||
                     node.type === 'InlineComponent' ||
+                    node.type === 'Slot' ||
                     node.type === 'SlotTemplate' ||
                     node.type === 'Title') &&
                     didSelfClose) ||
-                    node.type === 'Slot' ||
                     node.type === 'Window' ||
                     selfClosingTags.indexOf(node.name) !== -1 ||
                     isDoctypeTag);

diff --git a/test/printer/samples/self-closing-tags-lenient.html b/test/printer/samples/self-closing-tags-lenient.html
@@ -0,0 +1,2 @@
+<slot />
+<slot></slot>
diff --git a/test/printer/samples/self-closing-tags.html b/test/printer/samples/self-closing-tags.html
@@ -6,6 +6,10 @@
 
 <MyComponent />
 
+<!-- TODO: self-closing slot shouldn't be allowed in the next major version -->
+<slot />
+<slot></slot>
+
 <img />
 
 <input />