This repository has been archived by the owner on Oct 13, 2022. It is now read-only.
Do not cache with Cache API if cache mode is only-if-cached #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation tried to cache only-if-cached by changing request mode but it doesn't work because the property is readonly. However, caching responses cached with HTTP Cache again with Cache API does not make sense anyway. Just do not cache it, and leave it to HTTP cache.
|
this makes sense, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation tried to cache
only-if-cachedby changingrequest mode but it doesn't work because the property is readonly.
However, caching responses cached with HTTP Cache again with Cache API
does not make sense anyway. Just do not cache it, and leave it to HTTP
cache.
Resolves #34 (comment). I made this change according to WHATWG Fetch Standard. Please tell me if you found something incompatible with the specification.