This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
replace onload with addEventListener in inject_styles #1790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple dynamically imported components are loaded, only one of them resolves the promise. Upon further investigation, I found out that those components were loading
.css
files andinject_styles
function was usingonload
in order to resolveinject_styles
promise.If two components use the same
css
file, the firstonload
will be overridden by the second one.The solution is to replace
onload
withaddEventListener("load", ...
.@Rich-Harris pushed a fix for this in svelte kit (kit#347)