revamp(repl): Isolate each REPL instance #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dummdidumm
reviewed
May 23, 2023
| @@ -84,6 +84,8 @@ | |||
| ast = compiled.ast; | |||
| } | |||
|
|
|||
| const { module_editor } = /** @type {import('../types').ReplContext}*/ (getContext('REPL')); | |||
There was a problem hiding this comment.
To avoid type casts, repetition of a string etc I suggest to move the set/getContext into a separate file like
// repl-context.js
const key = {}
/** @returns {..} */
export function getREPLContext() {
return getContext(key);
}
/** @param {..} */
export function setREPLContext(value) {
setContext(key, value);
}There was a problem hiding this comment.
If it's in its own file, I'm scared if it will undo the isolation. As in, if I have multiple <Repl>, won't they all have access to this same getContext in this case?
There was a problem hiding this comment.
Ok this works. I still don't understand how, but it works 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.