finalize

sveltejs · Sep 4, 2024 · 0103b49 · 0103b49
1 parent d166d71
commit 0103b49
Showing 1 changed file with 23 additions and 33 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -38,47 +38,37 @@ jobs:
           name: extension-${{ github.sha }}
           path: workspace/extension/build/svelte-devtools.zip
 
-  sign:
+  publish:
     runs-on: ubuntu-latest
     needs: [manifest, bundle]
 
-    # if: |
-    #   github.repository == 'sveltejs/svelte-devtools' &&
-    #   github.event_name == 'push' && github.ref == 'refs/heads/master' &&
-    #   startsWith(github.event.head_commit.message, format('~ v{0}', needs.manifest.outputs.version))
+    if: |
+      github.repository == 'sveltejs/svelte-devtools' &&
+      github.event_name == 'push' && github.ref == 'refs/heads/master' &&
+      startsWith(github.event.head_commit.message, format('~ v{0}', needs.manifest.outputs.version))
 
     steps:
       - uses: actions/checkout@v4
       - uses: pnpm/action-setup@v4
       - uses: actions/download-artifact@v4
-      - working-directory: extension-${{ github.sha }}
-        run: ls -al
-
-      # - working-directory: extension-${{ github.sha }}
-      #   run: |
-      #     pnpm dlx web-ext sign --channel unlisted \
-      #     --api-key ${{ secrets.WEB_EXT_API_KEY }} \
-      #     --api-secret ${{ secrets.WEB_EXT_API_SECRET }}
 
-      # - working-directory: extension-${{ github.sha }}
-      #   env:
-      #     GH_TOKEN: ${{ github.token }}
-      #   run: | # https://cli.github.com/manual/gh_release_create
-      #     gh release create v${{ needs.manifest.outputs.version }} \
-      #     svelte-devtools.zip web-ext-artifacts/*.xpi#svelte-devtools.xpi \
-      #     --title ${{ needs.manifest.outputs.version }} \
-      #     --draft --generate-notes --notes '
-      #     Built from ${{ github.event.head_commit.id }} at https://github.com/sveltejs/svelte-devtools/actions/runs/${{ github.run_id }}
-      #     - Chrome Web Store: https://chrome.google.com/webstore/detail/svelte-devtools/kfidecgcdjjfpeckbblhmfkhmlgecoff
-      #     - Firefox Signed Add-on: https://github.com/sveltejs/svelte-devtools/releases/download/v${{ needs.manifest.outputs.version }}/svelte-devtools.xpi
-      #     ---'
+      - working-directory: extension-${{ github.sha }}
+        run: |
+          pnpm dlx web-ext sign --channel unlisted \
+          --api-key ${{ secrets.WEB_EXT_API_KEY }} \
+          --api-secret ${{ secrets.WEB_EXT_API_SECRET }}
 
-  # TODO: publish to Chrome Web Store
-  # publish:
-  #   runs-on: ubuntu-latest
-  #   needs: bundle
+      - working-directory: extension-${{ github.sha }}
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: | # https://cli.github.com/manual/gh_release_create
+          gh release create v${{ needs.manifest.outputs.version }} \
+          svelte-devtools.zip web-ext-artifacts/*.xpi#svelte-devtools.xpi \
+          --title ${{ needs.manifest.outputs.version }} \
+          --draft --generate-notes --notes '
+          Built from ${{ github.event.head_commit.id }} at https://github.com/sveltejs/svelte-devtools/actions/runs/${{ github.run_id }}
+          - Chrome Web Store: https://chrome.google.com/webstore/detail/svelte-devtools/kfidecgcdjjfpeckbblhmfkhmlgecoff
+          - Firefox Signed Add-on: https://github.com/sveltejs/svelte-devtools/releases/download/v${{ needs.manifest.outputs.version }}/svelte-devtools.xpi
+          ---'
 
-  #   steps:
-  #     - uses: actions/download-artifact@v4
-  #       with:
-  #         name: extension-${{ github.sha }}
+      # TODO: publish to Chrome Web Store