Skip to content

Conversation

manuel3108
Copy link
Member

@manuel3108 manuel3108 commented Jun 20, 2025

Adds sv, Relates sveltejs/cli#622

@manuel3108
Copy link
Member Author

If i undersand that correctly pnpm audit is running on this repo here, and failing here and not in sv. Let me check

@manuel3108
Copy link
Member Author

Running pnpm update fixes the issue, not sure if you want that though

@manuel3108 manuel3108 marked this pull request as ready for review June 21, 2025 11:03
@dominikg
Copy link
Member

main has been updated and should no longer have audit errors, changes to package.json & lockfile can be reverted here

@manuel3108
Copy link
Member Author

Updated everything, this should be good to go

@dominikg
Copy link
Member

trying to run pnpm test sv locally i got an error from drizzle tests regarding docker

 FAIL   addons  _tests/drizzle/test.ts [ packages/addons/_tests/drizzle/test.ts ]
Error: Command failed: docker compose up --detach
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

 ❯ _tests/drizzle/test.ts:20:2
     18|  if (noDocker) return;
     19|  const cwd = path.dirname(fileURLToPath(import.meta.url));
     20|  execSync('docker compose up --detach', { cwd, stdio: 'pipe' });
       |  ^
     21| 
     22|  return () => {

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

@dominikg
Copy link
Member

https://github.com/sveltejs/svelte-ecosystem-ci/actions/runs/16991175280/job/48170676793 passed so docker is available on gh runner. for local runs you either have to exclude sv or start docker until sv suite handles the error more gracefully.

@dominikg dominikg merged commit e1a39ae into main Aug 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants