Added style AST to parser services #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fc476cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marekdedic
commented
May 22, 2023
marekdedic
commented
May 22, 2023
|
I think this could be optimized by only parsing when the AST is demanded for the first time (and caching it for subsequent requests), but that can be added later |
ota-meshi
reviewed
May 24, 2023
ota-meshi
reviewed
May 24, 2023
Pull Request Test Coverage Report for Build 5092436135
💛 - Coveralls |
ota-meshi
requested changes
May 28, 2023
|
I added tests while debugging the offset. I'm on the fence about the offset re-calculation, see the specific comment. Other than that, good to go as far as I am concerned... |
…on for PostCSS nodes
ota-meshi
approved these changes
Jun 10, 2023
|
Thank you for the reviews, re-reviews and consultation of the correct approach! :) |
This was referenced Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative proposal to #318, see #318 (comment)