Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve let directive type #395

Merged
merged 7 commits into from
Aug 21, 2023
Merged

feat: improve let directive type #395

merged 7 commits into from
Aug 21, 2023

Conversation

ota-meshi
Copy link
Member

Related to #394

This PR improves assigning the correct let directive type when the component type is available.

However, since @typescript-eslint/parser cannot be used to retrieve component types, users should use the experimental parser typescript-eslint-parser-for-extra-files instead. .
If the user is using @typescript-eslint/parser it will be the same as before.

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

🦋 Changeset detected

Latest commit: 93373cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Aug 16, 2023

Pull Request Test Coverage Report for Build 5877142839

  • 29 of 33 (87.88%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 90.517%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/converts/attr.ts 25 29 86.21%
Totals Coverage Status
Change from base Build 5877064972: -0.1%
Covered Lines: 2213
Relevant Lines: 2361

💛 - Coveralls

@ota-meshi ota-meshi merged commit d9cb8ae into main Aug 21, 2023
@ota-meshi ota-meshi deleted the let-type branch August 21, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants