Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for $bindable() scope analysis #527

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

ota-meshi
Copy link
Member

This PR will give the $bindable() prop a virtual reference, letting ESLint rules know that it's a two-way bound variable.


See sveltejs/eslint-plugin-svelte#768

Copy link

changeset-bot bot commented Jun 9, 2024

🦋 Changeset detected

Latest commit: 25d5c10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ota-meshi ota-meshi mentioned this pull request Jun 9, 2024
18 tasks
@coveralls
Copy link

coveralls commented Jun 9, 2024

Pull Request Test Coverage Report for Build 9434693869

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 90.667%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/analyze-scope.ts 30 34 88.24%
Totals Coverage Status
Change from base Build 9261561260: -0.07%
Covered Lines: 2814
Relevant Lines: 2993

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 9, 2024

Pull Request Test Coverage Report for Build 9434700125

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 90.667%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/analyze-scope.ts 30 34 88.24%
Totals Coverage Status
Change from base Build 9261561260: -0.07%
Covered Lines: 2814
Relevant Lines: 2993

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 9, 2024

Pull Request Test Coverage Report for Build 9436463216

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 90.667%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/analyze-scope.ts 30 34 88.24%
Totals Coverage Status
Change from base Build 9436461869: -0.07%
Covered Lines: 2814
Relevant Lines: 2993

💛 - Coveralls

@ptrxyz
Copy link

ptrxyz commented Jun 9, 2024

Just came by to say thanks! I opened the issue this PR fixes and it's great seeing this fixed -- especially in such a short time! So thank you a lot @ota-meshi. Great work as always, keep it up!

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit d92287d into main Jun 10, 2024
13 checks passed
@ota-meshi ota-meshi deleted the bindable-scope branch June 10, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants