-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update svelte to 5.0.0-next.181 and fix for {:else if}
#548
Conversation
🦋 Changeset detectedLatest commit: a5241cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 9884323520Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
baseStart = Math.min(baseStart, getWithLoc(getTestFromIfBlock(c)).start); | ||
const contentStart = getWithLoc(getTestFromIfBlock(c)).start; | ||
if (contentStart <= c.start) { | ||
return startBlockIndex(ctx.code, contentStart - 1, ":else"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workaround is still necessary because we need it to work with svelte v4.
Oh I think you made a commit for this to main branch. |
Oh, sorry. I made a mistake once and thought I had put it back, but it seems I made another mistake 😓 |
I reverted the main branch and rebased this PR 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should handle this issue because I changed this AST spec, but thank you so much!
This PR updates the svelte version and fixes the wrong location and token of
{:else if}
nodes when using the updated svelte.Also, since Svelte no longer provides types for AST nodes, I have added code to work around that.