Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change the parser to an ESM-only package #599

Merged
merged 4 commits into from
Dec 2, 2024
Merged

feat!: change the parser to an ESM-only package #599

merged 4 commits into from
Dec 2, 2024

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Nov 30, 2024

This PR changes the parser to an ESM-only package.

#598 needs to be merged first.

Copy link

changeset-bot bot commented Nov 30, 2024

🦋 Changeset detected

Latest commit: 876fa4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ota-meshi ota-meshi linked an issue Nov 30, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Nov 30, 2024

Pull Request Test Coverage Report for Build 12110297464

Details

  • 245 of 252 (97.22%) changed or added relevant lines in 43 files are covered.
  • 258 unchanged lines in 22 files lost coverage.
  • Overall coverage increased (+4.8%) to 94.813%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/espree.ts 7 14 50.0%
Files with Coverage Reduction New Missed Lines %
src/context/unique.ts 1 87.5%
src/parser/sort.ts 1 80.95%
src/parser/typescript/set-parent.ts 1 88.46%
src/parser/template.ts 2 82.69%
src/utils/index.ts 3 91.89%
src/parser/converts/block.ts 3 98.57%
src/parser/typescript/restore.ts 4 94.77%
src/parser/style-context.ts 4 93.1%
src/parser/parser-options.ts 4 90.55%
src/parser/espree.ts 5 72.41%
Totals Coverage Status
Change from base Build 12110190049: 4.8%
Covered Lines: 10176
Relevant Lines: 10613

💛 - Coveralls

@ota-meshi ota-meshi force-pushed the esm branch 2 times, most recently from 478af98 to a21fdbd Compare December 1, 2024 08:10
@ota-meshi ota-meshi marked this pull request as ready for review December 1, 2024 08:10
Copy link

pkg-pr-new bot commented Dec 1, 2024

Open in Stackblitz

npm i https://pkg.pr.new/svelte-eslint-parser@599

commit: 6eb3492

Copy link

pkg-pr-new bot commented Dec 1, 2024

Open in Stackblitz

npm i https://pkg.pr.new/svelte-eslint-parser@599

commit: a21fdbd

@baseballyama baseballyama merged commit cefd17a into main Dec 2, 2024
13 checks passed
@baseballyama baseballyama deleted the esm branch December 2, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make this an ESM-only package
3 participants