Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AST node for function bindings #647

Merged
merged 3 commits into from
Jan 15, 2025
Merged

feat: add AST node for function bindings #647

merged 3 commits into from
Jan 15, 2025

Conversation

ota-meshi
Copy link
Member

close #646

Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: 0cb7429

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Jan 15, 2025

Pull Request Test Coverage Report for Build 12781652640

Details

  • 133 of 136 (97.79%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 94.732%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/context/script-let.ts 68 69 98.55%
src/parser/converts/attr.ts 48 50 96.0%
Totals Coverage Status
Change from base Build 12780293638: 0.01%
Covered Lines: 10451
Relevant Lines: 10907

💛 - Coveralls

Copy link

pkg-pr-new bot commented Jan 15, 2025

Open in Stackblitz

npm i https://pkg.pr.new/svelte-eslint-parser@647

commit: 0cb7429

Copy link

pkg-pr-new bot commented Jan 15, 2025

Open in Stackblitz

npm i https://pkg.pr.new/svelte-eslint-parser@647

commit: 0cb7429

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@baseballyama baseballyama merged commit 10ffeec into main Jan 15, 2025
13 checks passed
@baseballyama baseballyama deleted the fn-bind branch January 15, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positives for bind:property={get, set} in no-sequences
3 participants