-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ๐ธ add scss support for tilde (~) imports #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisermann
force-pushed
the
feat/support-scss-tilde-import
branch
from
November 7, 2020 15:23
61e15a2
to
74d3d8b
Compare
kaisermann
force-pushed
the
feat/support-scss-tilde-import
branch
from
November 8, 2020 13:29
241d1ec
to
cc65464
Compare
kaisermann
force-pushed
the
feat/support-scss-tilde-import
branch
15 times, most recently
from
November 8, 2020 14:36
eafe7c9
to
d2dc63b
Compare
kaisermann
force-pushed
the
feat/support-scss-tilde-import
branch
from
November 8, 2020 14:38
d2dc63b
to
4a270c9
Compare
Not sure why the windows test is failing ๐ข |
kaisermann
force-pushed
the
feat/support-scss-tilde-import
branch
2 times, most recently
from
November 9, 2020 14:11
3e69e25
to
4a270c9
Compare
kaisermann
force-pushed
the
feat/support-scss-tilde-import
branch
4 times, most recently
from
November 10, 2020 13:02
5cbcf7c
to
665f1fa
Compare
kaisermann
force-pushed
the
feat/support-scss-tilde-import
branch
from
November 10, 2020 13:05
665f1fa
to
360790a
Compare
@kaisermann Hi, do you know why the windows test isn't working? I didn't even know certain NodeJS modules/features are platform-dependent ๐ฎ |
@GitGangGuy Nope, no idea. The file is there ๐คท However, it may work if I read it manually and use the |
kaisermann
force-pushed
the
feat/support-scss-tilde-import
branch
from
November 17, 2020 13:19
7d92077
to
2026a3f
Compare
kaisermann
force-pushed
the
feat/support-scss-tilde-import
branch
from
November 17, 2020 13:19
2026a3f
to
215bcbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
โ Closes: #277
edit 1:
Just gotta do a test for it ๐edit 2:
Tests are failing now, not sure why. See sass/node-sass-middleware#104Can't use thedone
forrenderSync
runs.Current challenge:
it seems the sass compiler doesn't pass an importer's returned value through the
includePaths
paths, so it needs to return an absolute path. We use theurl
andprev
(source) arguments to resolve it, but, for some reason, the. Needed to passprev
value is coming asstdin
instead of the importer path.file
alongside the rest of the options.edit 3:
Need to rewrite that importer, the logic is wrong. It will stop on the first node_modules found, even if there's no package with the specified path.
References:
https://github.com/matthewdavidson/node-sass-tilde-importer/blob/master/index.js
https://sass-lang.com/documentation/js-api#importer