Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5 #562

Merged
merged 21 commits into from
Dec 10, 2022
Merged

v5 #562

merged 21 commits into from
Dec 10, 2022

Conversation

kaisermann
Copy link
Member

@kaisermann kaisermann commented Dec 10, 2022 •
edited
Loading

Closes #504, #559, #485, #452, #508. This PR basically does what is described in #504:

  • Bumps minimum node version from 10 to 14
  • Remove node-sass support. libSass (aka node-sass) was deprecated a while ago.. Use sass instead.
  • Remove support for the type="text/..." attribute (was deprecated)
  • Remove support for custom default languages .defaults (was deprecated)

From #504 (cc @dummdidumm)

Only support the new SASS API (right now we only support the legacy API). This means bumping the peer dep.

This will be the only thing not implemented right now as I'm not managing to make it work in the test environment. There's also a problem with sync/async importers which I'm not sure how to deal with just yet.

@benmccann
feat: drop Node 10 and 12. Add 16 and 18 (#561)
55c051d 
* Drop Node 10 and 12. Add 16 and 18
* Upgrade a couple dependencies

BREAKING CHANGE: minimum node version changed to v14
@kaisermann kaisermann marked this pull request as draft December 10, 2022 10:02
@kaisermann kaisermann mentioned this pull request Dec 10, 2022
Merged
@kaisermann
Copy link
Member Author

kaisermann commented Dec 10, 2022 •
edited
Loading

Updating to sass only and replacing the render call with compileString is harder than I thought 😅

@kaisermann
Copy link
Member Author

@dummdidumm The result of the typescript transformer still returns a diagnostics list alongside the rest of the Processed result. Is this used somewhere within the language server or in any other tool? Otherwise, I think we could remove this

@kaisermann kaisermann mentioned this pull request Dec 10, 2022
Merged
4 tasks
bato3 and others added 2 commits December 10, 2022 13:40
@bato3 @kaisermann
docs: tell, that we use legacy api (#453)
eb74349 
* [sass] we use leagacy api

* Tell, that we use Legacy API

Co-authored-by: Christian Kaisermann <christian@kaisermann.me>
@kaisermann
chore: remove unused method
f5c161b
@kaisermann
fix: 🐛 remove support for 'type' attribute
2f2782d 
Please use the `lang="..."` attribute to identify the language of a
style or script tag instead

BREAKING CHANGE: 🧨 Cannot use "type" attribute to identify the language of a style or
script tag anymore. Use `lang` instead
@kaisermann
test: fix scss dependencies test
80ef8f4
@kaisermann kaisermann self-assigned this Dec 10, 2022
@kaisermann kaisermann changed the title v5 WIP - v5 Dec 10, 2022
kaisermann
kaisermann commented Dec 10, 2022
View reviewed changes
src/transformers/scss.ts
@@ -59,24 +38,17 @@ const transformer: Transformer<Options.Sass> = async ({
filename,
options = {},
}) => {
let implementation = options?.implementation ?? sass;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since node-sass is deprecated, I think we might as well remove support for it altogether.

@kaisermann kaisermann marked this pull request as ready for review December 10, 2022 12:58
@kaisermann kaisermann changed the title WIP - v5 v5 Dec 10, 2022
@kaisermann
feat: 🎸 bump minimum node version to 14
30a9287 
BREAKING CHANGE: 🧨 Minimum node version was bumped from 9 to 14
@kaisermann kaisermann mentioned this pull request Dec 10, 2022
Closed
@kaisermann
fix: 🐛 remove support for custom default languages
ea19ca4 
BREAKING CHANGE: 🧨 Languages must be explicitly defined via the lang attribute.
This was referenced Dec 10, 2022
Closed
Closed
Closed
benmccann
benmccann reviewed Dec 10, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@kaisermann kaisermann mentioned this pull request Dec 10, 2022
Closed
@kaisermann kaisermann merged commit 537b975 into main Dec 10, 2022
@kaisermann
Copy link
Member Author

@benmccann Just released v5 🎉 those installation errors should stop now 🙏

@dummdidumm
Copy link
Member

@dummdidumm The result of the typescript transformer still returns a diagnostics list alongside the rest of the Processed result. Is this used somewhere within the language server or in any other tool? Otherwise, I think we could remove this

Nope, not used, so can be removed.
Thank you for releasing the next major 🎉

@benmccann
Copy link
Member

thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

@dummdidumm dummdidumm Awaiting requested review from dummdidumm

Assignees

@kaisermann kaisermann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 5 (major release) planning
4 participants
@kaisermann @dummdidumm @benmccann @bato3