Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fall back to verbatimModuleSyntax if possible #649

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

dummdidumm
Copy link
Member

In case no tsconfig is found whatsoever, enable verbatimModuleSyntax to prevent stripping unused imports.

Also fix a related issue where the config passed manually was not properly parsed.

Also print warning message in bold to make it more visible.

related to #643

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to run pnpm lint!)

Tests

  • Run the tests with npm test or pnpm test

In case no tsconfig is found whatsoever, enable `verbatimModuleSyntax` to prevent stripping unused imports.

Also fix a related issue where the config passed manually was not properly parsed.

Also print warning message in bold to make it more visible.

related to #643
@dummdidumm dummdidumm merged commit 9e5fe59 into main Jul 9, 2024
20 checks passed
@dummdidumm dummdidumm deleted the options-robustness branch July 9, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant