Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Svelte 3/4 in playground #433

Closed
Rich-Harris opened this issue Oct 17, 2024 · 3 comments · Fixed by #499 or #500
Closed

Support Svelte 3/4 in playground #433

Rich-Harris opened this issue Oct 17, 2024 · 3 comments · Fixed by #499 or #500

Comments

@Rich-Harris
Copy link
Member

right now we don't respect ?version, we just use latest (it's bundled into the worker). we should fix that, ideally before launch since it will break existing /repl links otherwise

@brunnerh
Copy link
Member

brunnerh commented Oct 22, 2024

@Rich-Harris @dummdidumm This appears to still be broken because the compilation runs in a worker.

There is a function getBtoa which tests for window.btoa and Buffer and finds neither.
globalThis.btoa would be available.

Gets triggered on style source map generation.

Example

<h1>Hello</h1>
<style>h1 { color: red; }</style>

@brunnerh brunnerh reopened this Oct 22, 2024
@brunnerh
Copy link
Member

Also: The JS output panel appears to still show Svelte 5 output, possibly the other panels as well.

@dummdidumm
Copy link
Member

huh, why am I not able to reproduce the btoa issue locally? Very strange.

dummdidumm added a commit that referenced this issue Oct 22, 2024
closes #433

- handle Svelte 3/4 in the bundler worker
- handle Svelte 3/4 in the compiler worker
- fix race condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants