Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent premature keydown interruptions during actions tutorial #1168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

spacepumpkin
Copy link

@spacepumpkin spacepumpkin commented Feb 24, 2025

A note on documentation PRs

If this is a documentation PR (i.e. changing content within apps/svelte.dev/content/docs), then this is the wrong repository to make those changes. The content in this folder is synced from other repositories. Therefore, these changes should be made in their respective repositories (at https://github.com/sveltejs/svelte or https://github.com/sveltejs/kit, or example).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.

Closes #700

Bug:

  • When following the actions tutorial to edit the actions.svelte.js file, key presses and focus are interrupted after adding use:trapFocus, likely due to the focusable()[0]?.focus(); within the $effect.

Test Steps:

Copy link

vercel bot commented Feb 24, 2025

@spacepumpkin is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tutorial/svelte/actions keeps interrupting typing in the code window
1 participant