Skip to content

Conversation

M0ST4FA
Copy link

@M0ST4FA M0ST4FA commented Oct 7, 2025

Issue #443

Make sure the embiggen button never embiggens rectangle dimensions beyond MAX_SIZE.

Note: the same bug exists in "app a" but I don't understand why there are two apps in the first place, so I chose one randomly. Also, I checked the documentation repo and I couldn't find the tutorials in the directory tree, so sorry if the PR is in the wrong place.

Make sure the embiggen button never embiggens rectangle dimensions beyond MAX_SIZE.
Copy link

vercel bot commented Oct 7, 2025

@M0ST4FA is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@Conduitry
Copy link
Member

There are two apps because one is what the user is initially presented with and the other is the solved version.

This isn't the right fix, though. We handle MAX_SIZE in a later tutorial - https://svelte.dev/tutorial/svelte/getters-and-setters

I think, if anything, perhaps MAX_SIZE should be removed from the earlier tutorial.

@M0ST4FA M0ST4FA closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants