-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup redirects from obsolete sites #538
Conversation
create a vercel.json for each of them and redirect to the corresponding pages on svelte.dev
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
"$schema": "https://openapi.vercel.sh/vercel.json", | ||
"redirects": [ | ||
{ | ||
"source": "/(.*)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be cumbersome; we basically need to go through all the links and find out the right equivalent on the new one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah right, because of the /tutorial/svelte
vs /tutorial/kit
thing
"source": "/docs/(.*)", | ||
"destination": "https://svelte.dev/docs/kit/$1", | ||
"permanent": true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have a catch-all fallback, so that people at least end up on the right site if they somehow find a bad link?
ending my workday now, feel free to take over |
apps/learn.svelte.dev/vercel.json
Outdated
{ | ||
"source": "/(.*)", | ||
"destination": "https://svelte.dev/$1", | ||
"permanent": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to skip permanent
on whatever fallback we have for this one so that if there's some URL we missed we have an opportunity to fix it
should we also add a |
Didn't get around to adding this here, but I think for that one we should have an app, so that we can redirect the hash links - there's too many of them by now to not migrate them |
i think it'll break all the hash links — might need to redirect from the browser, not sure working on the tutorial slugs |
alright, i feel good about this — will merge and start updating the site configs |
"permanent": true | ||
}, | ||
{ | ||
"source": "/docs/modules", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a URL for each individual type here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're going to have to build an app which checks what the hash is and redirects it appropriately to the correct page
create a vercel.json for each of them and redirect to the corresponding pages on svelte.dev