Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure shared file is resolved properly in all situations #566

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

dummdidumm
Copy link
Member

using a relative import means it may be relatively imported from within a node module, which leads to wrong results

fixes #555

A note on documentation PRs

If this is a documentation PR (i.e. changing content within apps/svelte.dev/content/docs), then this is the wrong repository to make those changes. The content in this folder is synced from other repositories. Therefore, these changes should be made in their respective repositories (at https://github.com/sveltejs/svelte or https://github.com/sveltejs/kit, or example).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.

using a relative import means it may be relatively imported from within a node module, which leads to wrong results

fixes #555
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kit-svelte-dev 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:16am
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:16am
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:16am
svelte-5-preview 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:16am
svelte-dev 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:16am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find "/dist/__shared.js"
1 participant