Skip to content

fix: speed up build by ensuring stable cache #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 23, 2024
Merged

fix: speed up build by ensuring stable cache #569

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eb84aa9
test
dummdidumm Oct 23, 2024
eda56a8
test
dummdidumm Oct 23, 2024
bf76bd9
lets see whats included
dummdidumm Oct 23, 2024
ba56852
fix
dummdidumm Oct 23, 2024
0773f64
more diagnostics, but mostly fix my stupid bug lol
dummdidumm Oct 23, 2024
582b28a
oops
dummdidumm Oct 23, 2024
74a6add
Update apps/svelte.dev/content/tutorial/03-sveltekit/02-routing/01-pa…
dummdidumm Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/site-kit/src/lib/markdown/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import MagicString from 'magic-string';
import { createHash, Hash } from 'node:crypto';
import fs from 'node:fs';
import process from 'node:process';
import path from 'node:path';
import ts from 'typescript';
import * as marked from 'marked';
Expand Down Expand Up @@ -28,9 +29,21 @@ const theme = createCssVariablesTheme({
fontStyle: true
});

// Hash the contents of this file and its dependencies so that we get a new cache in case we have changed
// how the markdown is rendered (whose logic live here). This is to avoid serving stale code snippets.
const hash = createHash('sha256');
hash.update(fs.readFileSync('../../pnpm-lock.yaml', 'utf-8'));
hash_graph(hash, fileURLToPath(import.meta.url));
// CAREFUL: update this URL in case you ever move this file or start the dev/build process from another directory
const original_file = '../../packages/site-kit/src/lib/markdown/renderer.ts';
if (!fs.existsSync(original_file)) {
throw new Error(
'Update the path to the markdown renderer code. Current value: ' +
original_file +
' | Current cwd: ' +
process.cwd()
);
}
hash_graph(hash, original_file);
const digest = hash.digest().toString('base64').replace(/\//g, '-');

/**
Expand Down
Loading