Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move DB stuff over from sites repo #628

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: move DB stuff over from sites repo #628

wants to merge 5 commits into from

Conversation

benmccann
Copy link
Member

ref #536. and also mentioned by french translation folks

Am I correct in assuming this should move here and is still used by the new site?

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kit-svelte-dev 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:53pm
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:53pm
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:53pm
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:53pm
svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:53pm

@dummdidumm
Copy link
Member

Should we put this stuff inside a big contributing.md file?

@Rich-Harris
Copy link
Member

Feels like this should go in apps/svelte.dev, no?

Are these instructions sufficient? Presumably you also need a GitHub app set up for auth, otherwise you can't save to the db anyway

@benmccann
Copy link
Member Author

Should we put this stuff inside a big contributing.md file?

Done

Feels like this should go in apps/svelte.dev, no?

Done

Are these instructions sufficient? Presumably you also need a GitHub app set up for auth, otherwise you can't save to the db anyway

No idea. There's at least less missing parts now than before. But I don't really have this stuff setup or know enough to document it fully

@Rich-Harris
Copy link
Member

I don't think there's much point merging a PR until we've validated that it works

@benmccann
Copy link
Member Author

My main concern was trying to cleanup the sites repo without losing anything

@SrGeneroso
Copy link

would be possible to add the playground as an iframe from svelte.dev so the translation sites doesn't have to host their own db?
Since the playground (can i keep calling it repl?) need the github auth and a separate db I think that would fragmentate userbase. Would be nice to have all the users in the same db. Would that be very complicated?
https://sveltefr.dev/playground/hello-world?version=5.1.3

@Rich-Harris
Copy link
Member

Stuff like this is why we'd prefer to internationalise svelte.dev than have a bunch of different sites with translations

@benmccann
Copy link
Member Author

I deleted all files from the sites repo except for the HN example, so these files only live here. It is impossible for me to do anything else in this PR because I don't know what the rest of the setup steps are, so I can't document them. I'd be happy if someone would like to complete this PR. Otherwise, I think this is still worth merging as some help is better than none and folks aren't going to know to look in the PR queue to find the files that are necessary to setup the DB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants