chore: improve signal runtime perf (#12093)

* chore: improve signal runtime perf * chore: improve signal runtime perf * chore: improve signal runtime perf
sveltejs · Jun 19, 2024 · 04eaf17 · 04eaf17
1 parent c7f6805
commit 04eaf17
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.changeset/sweet-bottles-check.md b/.changeset/sweet-bottles-check.md
@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+chore: improve runtime performance of capturing reactive signals
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -357,11 +357,7 @@ export function execute_reaction_fn(signal) {
 
 					if (reactions === null) {
 						dependency.reactions = [signal];
-					} else if (reactions[reactions.length - 1] !== signal) {
-						// TODO: should this be:
-						//
-						// } else if (!reactions.includes(signal)) {
-						//
+					} else if (reactions[reactions.length - 1] !== signal && !reactions.includes(signal)) {
 						reactions.push(signal);
 					}
 				}