perf: convert empty text nodes to comments

sveltejs · Aug 21, 2020 · 6df7989 · 6df7989
1 parent 82dc26a
commit 6df7989
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/runtime/internal/dom.ts b/src/runtime/internal/dom.ts
@@ -54,7 +54,7 @@ export function space() {
 }
 
 export function empty() {
-	return text('');
+	return document.createComment('');
 }
 
 export function listen(node: EventTarget, event: string, handler: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions | EventListenerOptions) {

diff --git a/test/runtime/samples/raw-mustache-inside-head/_config.js b/test/runtime/samples/raw-mustache-inside-head/_config.js
@@ -3,14 +3,14 @@ export default {
 		const btn = target.querySelector("button");
 		const clickEvent = new window.MouseEvent("click");
 
-		assert.equal(window.document.head.innerHTML.includes('<style>body { color: blue; }</style><style>body { color: green; }</style>'), true);
+		assert.equal(window.document.head.innerHTML.includes('<style>body { color: blue; }</style><!----><style>body { color: green; }</style>'), true);
 
 		await btn.dispatchEvent(clickEvent);
 
-		assert.equal(window.document.head.innerHTML.includes('<style>body { color: red; }</style><style>body { color: green; }</style>'), true);
+		assert.equal(window.document.head.innerHTML.includes('<style>body { color: red; }</style><!----><style>body { color: green; }</style>'), true);
 
 		await btn.dispatchEvent(clickEvent);
 
-		assert.equal(window.document.head.innerHTML.includes('<style>body { color: blue; }</style><style>body { color: green; }</style>'), true);
+		assert.equal(window.document.head.innerHTML.includes('<style>body { color: blue; }</style><!----><style>body { color: green; }</style>'), true);
 	}
 };