conflict

sveltejs · Jun 20, 2024 · bb38174 · bb38174
2 parents af16065 + 7f087c4
commit bb38174
Show file tree

Hide file tree

Showing 9 changed files with 33 additions and 8 deletions.
diff --git a/.changeset/pre.json b/.changeset/pre.json
@@ -529,6 +529,7 @@
     "strong-lemons-provide",
     "strong-pans-doubt",
     "stupid-parents-crash",
+    "sweet-bottles-check",
     "sweet-mangos-beg",
     "sweet-pens-sniff",
     "swift-donkeys-perform",

diff --git a/.changeset/sweet-bottles-check.md b/.changeset/sweet-bottles-check.md
@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+chore: improve runtime performance of capturing reactive signals
diff --git a/.changeset/twenty-gifts-develop.md b/.changeset/twenty-gifts-develop.md
@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+fix: remove document event listeners on unmount
diff --git a/benchmarking/run.js b/benchmarking/run.js
@@ -1,13 +1,19 @@
 import * as $ from '../packages/svelte/src/internal/client/index.js';
 import { benchmarks } from './benchmarks.js';
 
+let total_time = 0;
+let total_gc_time = 0;
+
 // eslint-disable-next-line no-console
 console.log('-- Benchmarking Started --');
 $.push({}, true);
 try {
 	for (const benchmark of benchmarks) {
+		const results = await benchmark();
 		// eslint-disable-next-line no-console
-		console.log(await benchmark());
+		console.log(results);
+		total_time += Number(results.time);
+		total_gc_time += Number(results.gc_time);
 	}
 } catch (e) {
 	// eslint-disable-next-line no-console
@@ -19,3 +25,8 @@ try {
 $.pop();
 // eslint-disable-next-line no-console
 console.log('-- Benchmarking Complete --');
+// eslint-disable-next-line no-console
+console.log({
+	total_time: total_time.toFixed(2),
+	total_gc_time: total_gc_time.toFixed(2)
+});
diff --git a/packages/svelte/CHANGELOG.md b/packages/svelte/CHANGELOG.md
@@ -1,5 +1,11 @@
 # svelte
 
+## 5.0.0-next.160
+
+### Patch Changes
+
+- chore: improve runtime performance of capturing reactive signals ([#12093](https://github.com/sveltejs/svelte/pull/12093))
+
 ## 5.0.0-next.159
 
 ### Patch Changes

diff --git a/packages/svelte/package.json b/packages/svelte/package.json
@@ -2,7 +2,7 @@
   "name": "svelte",
   "description": "Cybernetically enhanced web apps",
   "license": "MIT",
-  "version": "5.0.0-next.159",
+  "version": "5.0.0-next.160",
   "type": "module",
   "types": "./types/index.d.ts",
   "engines": {

diff --git a/packages/svelte/src/internal/client/render.js b/packages/svelte/src/internal/client/render.js
@@ -251,6 +251,7 @@ function _mount(Component, { target, anchor, props = {}, events, context, intro
 		return () => {
 			for (const event_name of registered_events) {
 				target.removeEventListener(event_name, bound_event_listener);
+				document.removeEventListener(event_name, bound_event_listener);
 			}
 			root_event_handles.delete(event_handle);
 			mounted_components.delete(component);

diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -357,11 +357,7 @@ export function execute_reaction_fn(signal) {
 
 					if (reactions === null) {
 						dependency.reactions = [signal];
-					} else if (reactions[reactions.length - 1] !== signal) {
-						// TODO: should this be:
-						//
-						// } else if (!reactions.includes(signal)) {
-						//
+					} else if (reactions[reactions.length - 1] !== signal && !reactions.includes(signal)) {
 						reactions.push(signal);
 					}
 				}

diff --git a/packages/svelte/src/version.js b/packages/svelte/src/version.js
@@ -6,5 +6,5 @@
  * https://svelte.dev/docs/svelte-compiler#svelte-version
  * @type {string}
  */
-export const VERSION = '5.0.0-next.159';
+export const VERSION = '5.0.0-next.160';
 export const PUBLIC_VERSION = '5';