dont warn on empty block for nbsp - fixes #1658

sveltejs · Aug 24, 2018 · c52a6f0 · c52a6f0
1 parent 4890d4d
commit c52a6f0
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/src/validate/html/index.ts b/src/validate/html/index.ts
@@ -14,7 +14,7 @@ function isEmptyBlock(node: Node) {
 	if (!/Block$/.test(node.type) || !node.children) return false;
 	if (node.children.length > 1) return false;
 	const child = node.children[0];
-	return !child || (child.type === 'Text' && !/\S/.test(child.data));
+	return !child || (child.type === 'Text' && !/[^ \r\n\f\v\t]/.test(child.data));
 }
 
 export default function validateHtml(validator: Validator, html: Node) {

diff --git a/test/validator/samples/non-empty-block-dev/_config.js b/test/validator/samples/non-empty-block-dev/_config.js
@@ -0,0 +1,3 @@
+export default {
+	dev: true
+};
diff --git a/test/validator/samples/non-empty-block-dev/input.html b/test/validator/samples/non-empty-block-dev/input.html
@@ -0,0 +1,3 @@
+{#if x}
+	&nbsp;
+{/if}
diff --git a/test/validator/samples/non-empty-block-dev/warnings.json b/test/validator/samples/non-empty-block-dev/warnings.json
@@ -0,0 +1 @@
+[]
-Original file line number
+Diff line change
@@ -0,0 +1,3 @@
+    {#if x}
+    	&nbsp;
+    {/if}