Skip to content

Commit

Permalink
fix: consider img with loading attribute not static (#14237)
Browse files Browse the repository at this point in the history
* fix: consider img with loading attribute not static

* chore: add comment for `is_static_element`

* chore: better comment

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
  • Loading branch information
paoloricciuti and benmccann authored Nov 10, 2024
1 parent 1e5a385 commit d207666
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/nice-chicken-wonder.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: consider img with loading attribute not static
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ function is_static_element(node) {
return false;
}

// We need to apply src and loading after appending the img to the DOM for lazy loading to work
if (node.name === 'img' && attribute.name === 'loading') {
return false;
}

if (node.name.includes('-')) {
return false; // we're setting all attributes on custom elements through properties
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { test } from '../../test';

export default test({
html: `<h1></h1><img src="..." loading="lazy" />`
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<h1></h1>
<img src="..." loading="lazy">

0 comments on commit d207666

Please sign in to comment.