-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] preventing brower zoom in svelte5 using onwheel
#13318
Comments
onwheel
onwheel
See discussion in #12639 |
so i'm guessing Rich is saying here, |
This is interesting because MDN states that the events are passive by default only on |
right, i think |
This was done previously to align with browser behavior, but the browser behavior actually only makes them passive on window/document/body. Since wheel events are not delegated, we can revert their passive-by-default setting. Closes #13318 For touchstart/touchmove we're not changing it because these events are delegated, which means they happen a lot more often on a target higher up the tree, which may cause jank.
This was done previously to align with browser behavior, but the browser behavior actually only makes them passive on window/document/body. Since wheel events are not delegated, we can revert their passive-by-default setting. Closes #13318 For touchstart/touchmove we're not changing it because these events are delegated, which means they happen a lot more often on a target higher up the tree, which may cause jank.
Describe the bug
svelte5
onwheel
breaks e.preventDefault.use
on:wheel
as quick workaround, but linter will nag.Reproduction
https://svelte-5-preview.vercel.app/#H4sIAAAAAAAACm2RQWvcMBCF_8ogArHJJmpy9NqGkIRSaKGUQg9xD15p7BVrj4Q0dpoa__ci29uF0pvmvWHep5lJNKbDILLXSVDdo8jEo3NiJ_jdxSKM2DGKnQh28CoqeVDeOC4rqrhDBmUHYijgKnDNmHxI92en9UZfjEWnipuBFBtLYEh57JE4wRSmaFWMd87jiMTP2NRDx0kKUsKmwcHbt4Aeflvbr_1r-E0B90vqvEZICVfYNKg4SVIoynW6lFBxZLqrtX6JAz-bwEjok-u3I2J3vbsw7WBydQhmxKypu4Bzuo1YHpTLyxYoPz6UX_-DmMvjQ1lRrs0Igd87LCpxqNWp9XYgfatsZ30GztBpD67W2lCbwb3Hfl8JiHEAcDCkMz6aUEwRfV6_DZYW4mL6CzwvB3li38EN_IhmBtOynjniajOurK586ow6GWohD-wtteWXTx-_PX5_yeVWw8FjfQqQK6ux_PckuVzkXLrzwBg8BNz6t81vbWD9plvKFuazwRYa8yuyuVLsRG-1aQxqkbEfcP45_wH2-Tl_mgIAAA==
Logs
Console Error:
Unable to preventDefault inside passive event listener invocation.
System Info
Severity
blocking an upgrade
The text was updated successfully, but these errors were encountered: