We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using named slots with a name that is a reserved keyword in JS, will create a broken snippet 👍🏻
Probably all of these will affect migration => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#keywords
Create a PR that will re-use the @migration-task logic => #14278
@migration-task
having
<slot name="new"> ... </slot>
will create following in migration:
{#snippet new()}
and results into the following error:
ts: 'new' is a reserved word in JavaScript and cannot be used here
No logs during migration
System: OS: macOS 15.1 CPU: (11) arm64 Apple M3 Pro Memory: 85.53 MB / 18.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 20.13.1 - ~/.nvm/versions/node/v20.13.1/bin/node npm: 10.5.2 - ~/.nvm/versions/node/v20.13.1/bin/npm pnpm: 9.7.0 - ~/.nvm/versions/node/v20.13.1/bin/pnpm bun: 1.1.30 - ~/.bun/bin/bun Browsers: Chrome: 130.0.6723.117 Safari: 18.1 npmPackages: svelte: ^5.0.0 => 5.1.15
annoyance
The text was updated successfully, but these errors were encountered:
fix: named slots with reserved keywords during migration (#14278)
0330618
Fixes named slots with a reserved keyword not working anymore after migration. Re-uses the @migration-task logic for invalid identifiers. Fixes #14277
fb873f9
811ab7a
Successfully merging a pull request may close this issue.
Describe the bug
Using named slots with a name that is a reserved keyword in JS, will create a broken snippet 👍🏻
Probably all of these will affect migration => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#keywords
Create a PR that will re-use the
@migration-task
logic => #14278Reproduction
having
will create following in migration:
and results into the following error:
ts: 'new' is a reserved word in JavaScript and cannot be used here
Logs
System Info
Severity
annoyance
The text was updated successfully, but these errors were encountered: