Skip to content

$props.id() output format clashes with Server Side Include format #16819

@brittharr

Description

@brittharr

Describe the bug

When SSIs are turned on in Nginx the server tries to parse <!--#text--> -- which is the same format output during SSR when $props.id() is used. Nginx can't parse this and the default is to print [an error occurred while processing the directive] in the html (replacing Svelte's hydration comment <!--#s1-->)

Would it be possible to change the format of the props_id() renderer output? Maybe like <!--$? That seems safe in the corresponding props_id hydration code too?

The current workaround is to not use this feature and pass ids as a prop to each component instance, but it would be nice to be able to use $props.id()

(I assume this is also an issue with Apache, etc. as they have the same SSI format but I've only observed it with Nginx)

Reproduction

https://github.com/brittharr/svelte-props-id

Static output here:
https://github.com/brittharr/svelte-props-id/blob/main/build/index.html#L20

Logs

System Info

All

Severity

annoyance

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions