-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty component 'computed' throws error. #452
Comments
I think allowing an empty |
Great, I'll take care of that. |
taylorzane
added a commit
to taylorzane/svelte
that referenced
this issue
Apr 5, 2017
…an empty object to prevent the component from compiling.
Rich-Harris
added a commit
that referenced
this issue
Apr 5, 2017
Fixed empty component 'computed' from throwing error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An empty component
computed
property causes svelte compiler to add an unnecessaryrecompute
call without actually adding therecompute
function.Version: 1.13.6
Smallest failing example:
Error:
recompute is not defined.
Seems like the error is going on here: src/generators/dom/index.js#L305-L309
In order to resolve this issue I see one of two options:
computed
is an empty object.computed
is invalid.I'll be happy to submit a PR, I just wanted to figure out the best course of action.
The text was updated successfully, but these errors were encountered: