Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add CSS scoping attribute to elements that don't need it #679

Closed
Rich-Harris opened this issue Jun 26, 2017 · 0 comments
Closed

Don't add CSS scoping attribute to elements that don't need it #679

Rich-Harris opened this issue Jun 26, 2017 · 0 comments

Comments

@Rich-Harris
Copy link
Member

The other side of the #678 coin — there's no sense in adding a svelte-123xyz attribute to an element that doesn't have a corresponding style:

<div>
  <p>this should have the attribute, the parent should not</p>
</div>

<style>
  p {
    color: red;
  }
</style>
Rich-Harris added a commit that referenced this issue Jun 26, 2017
Rich-Harris added a commit that referenced this issue Jul 3, 2017
Rich-Harris added a commit that referenced this issue Jul 5, 2017
Only apply svelte-123xyz attributes where necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant