Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ stripped from attribute values in SSR mode #741

Closed
Conduitry opened this issue Aug 1, 2017 · 1 comment
Closed

@ stripped from attribute values in SSR mode #741

Conduitry opened this issue Aug 1, 2017 · 1 comment

Comments

@Conduitry
Copy link
Member

<a href='mailto:hello@example.com'>email</a>

when run through the compiler in SSR mode produces

...
return `<a href="mailto:helloexample.com">email</a>`.trim();
...
@Conduitry
Copy link
Member Author

Looking at the code for this, I noticed something else: double quotes in attribute values in SSR are also not handled well -

<span title='"foo"'>foo</span>

produces

...
return `<span title=""foo"">foo</span>`.trim();
...

Rich-Harris added a commit that referenced this issue Aug 4, 2017
Rich-Harris added a commit that referenced this issue Aug 4, 2017
Rich-Harris added a commit that referenced this issue Aug 4, 2017
Rich-Harris added a commit that referenced this issue Aug 4, 2017
Fix escaping/unescaping of text and attributes in SSR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant