Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags and attributes should only be recomputed if necessary #768

Closed
Rich-Harris opened this issue Aug 14, 2017 · 0 comments · Fixed by #769
Closed

Tags and attributes should only be recomputed if necessary #768

Rich-Harris opened this issue Aug 14, 2017 · 0 comments · Fixed by #769

Comments

@Rich-Harris
Copy link
Member

REPL demo. If you have a tag like this...

{{someHelper(someUnchangingValue)}}

...someHelper will be reinvoked on every state change, regardless of whether someUnchangingValue has changed, which can cause sluggishness.
Rich-Harris added a commit that referenced this issue Aug 14, 2017
@Rich-Harris
do dirty check in _set, so we can easily skip unnecessary computation…
0f7e87c 
…s later (#768)
@Rich-Harris Rich-Harris mentioned this issue Aug 14, 2017
Merged
2 tasks
Rich-Harris added a commit that referenced this issue Aug 14, 2017
@Rich-Harris
Merge pull request #769 from sveltejs/gh-768
276b799 
skip updates where possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

skip updates where possible sveltejs/svelte
1 participant
@Rich-Harris