-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determining interactivity returning different results with latest version of aria-query
#8728
Comments
We may have to tweak the definition of
See what |
dummdidumm
added a commit
that referenced
this issue
Jun 19, 2023
closes #8728 Turns out all the removed previous test failures are indeed correct to be removed, according to the test adjustments in jsx-eslint/eslint-plugin-jsx-a11y#937
dummdidumm
added a commit
that referenced
this issue
Jun 19, 2023
closes #8728 Turns out all the removed previous test failures are indeed correct to be removed, according to the test adjustments in jsx-eslint/eslint-plugin-jsx-a11y#937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
#8724 removed four tests that started failing with the upgrade of
aria-query
andaxobject-query
and added four TODOselementRoles
fromaria-query
used to contain:But after #8724 it contains:
This gives different results when
element_interactivity
callsmatch_schema
because of the presence/absence ofattributes
:https://github.com/sveltejs/svelte/blob/d6f0b7bd5bacbe3ab2aae8dc43a6313cbf42b99a/packages/svelte/src/compiler/compile/utils/a11y.js#LL157C13-L157C13
Reproduction
Logs
No response
System Info
`aria-query` 5.1.3 and 5.2.1
Severity
annoyance
The text was updated successfully, but these errors were encountered: