Svelte 5: Static class fields are transformed incorrectly

[brunnerh]

Describe the bug

Static fields get converted into instance field/accessors.

Reproduction

<script>
	class Test {
		static value = $state(0)
	}
</script>
<input bind:value={Test.value} /> {Test.value}

REPL

Output:

class Test {
	#value = $.source(0);

	get value() {
		return $.get(this.#value);
	}

	set value(value) {
		$.set(this.#value, value);
	}
}

Correct output would probably be:

class Test {
    static #value = $.source(0);
    static get value() { return $.get(Test.#value); }
    static set value(value) { $.set(Test.#value, value); }
}

Logs

No response

System Info

REPL

Severity

annoyance

[trueadm]

This one is a tricky on however, I wonder if we should just not permit static runes on classes:

const x = class {
	static value = $state(0)
}

[brunnerh]

@trueadm It looks like one can also use this in static properties/methods to refer to the class itself.

(class {
    static value = 1;
    static get test() { return this.value; }
}).test // == 1

[Rich-Harris]

My inclination is to disallow it on static fields. If we change our minds later we can always allow it non-breakingly