Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect multiple animations #10192

Closed
wants to merge 3 commits into from
Closed

Conversation

navorite
Copy link
Contributor

@navorite navorite commented Jan 15, 2024

trims whitespace while at it, closes #10189

the first change fixes it, but I thought improving the parser whitespace handling for this case would be better and more consistent since we use it in the analyzing step, added a test case for both changes.

we can also prevent appending the magic string to the animation name if it is inside a comment

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 15, 2024

🦋 Changeset detected

Latest commit: 4a620c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 15, 2024

@navorite is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@navorite navorite marked this pull request as draft January 15, 2024 18:38
@navorite navorite marked this pull request as ready for review January 15, 2024 21:50
@navorite
Copy link
Contributor Author

navorite commented Feb 8, 2024

closing in favor of #10432

@navorite navorite closed this Feb 8, 2024
@navorite navorite deleted the fix-animation branch February 15, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Only first animation applied from comma-separated list
1 participant