-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
docs: fix repl login #10295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix repl login #10295
Conversation
|
|
hm, not sure why all these workflows are failing... (oh oops, I guess this is a known issue) |
|
@PuruVJ would you mind taking a look? |
|
bump? |
|
Thanks for the PR! AFAIK, the only way to test this change out is to merge and see whether it fixed it. Did you test it out locally on your own? Did it work? |
|
Yep, it worked locally for me :) |
|
Thanks! |
Fixes #9459
I believe the issue was other messages being sent to the repl prematurely, before the login completed (in my case, the messages were being spammed by React DevTools)
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint