Skip to content

Conversation

@xyzqm
Copy link

@xyzqm xyzqm commented Jan 25, 2024

Fixes #9459

I believe the issue was other messages being sent to the repl prematurely, before the login completed (in my case, the messages were being spammed by React DevTools)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: 95ff9ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@xyzqm
Copy link
Author

xyzqm commented Jan 25, 2024

hm, not sure why all these workflows are failing... (oh oops, I guess this is a known issue)

@xyzqm
Copy link
Author

xyzqm commented Jan 26, 2024

@PuruVJ would you mind taking a look?

@xyzqm
Copy link
Author

xyzqm commented Feb 9, 2024

bump?

@PuruVJ
Copy link
Collaborator

PuruVJ commented Feb 9, 2024

Thanks for the PR! AFAIK, the only way to test this change out is to merge and see whether it fixed it. Did you test it out locally on your own? Did it work?

@xyzqm
Copy link
Author

xyzqm commented Feb 9, 2024

Yep, it worked locally for me :)

@PuruVJ PuruVJ merged commit 2349ceb into sveltejs:svelte-4 Feb 12, 2024
@PuruVJ
Copy link
Collaborator

PuruVJ commented Feb 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants