Skip to content

Conversation

Not-Jayden
Copy link
Contributor

@Not-Jayden Not-Jayden commented Jan 31, 2024

The current type declaration incorrectly suggests $derived.call() will always return void, instead of the return type of the function it receives.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 31, 2024

🦋 Changeset detected

Latest commit: c0d07e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Not-Jayden Not-Jayden changed the title update call type fix: Update $derived.call type declaration Jan 31, 2024
@Not-Jayden Not-Jayden marked this pull request as ready for review January 31, 2024 06:07
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit f9ed9cf into sveltejs:main Jan 31, 2024
trueadm pushed a commit that referenced this pull request Jan 31, 2024
---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants