Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: faster HTML tags #10986

Merged
merged 2 commits into from
Mar 30, 2024
Merged

feat: faster HTML tags #10986

merged 2 commits into from
Mar 30, 2024

Conversation

Rich-Harris
Copy link
Member

some missed opportunities with {@html ...}:

  • if it's a single node (not uncommon), insert and return directly. no sense in wrapping it in an array
  • there's no need to clone the fragment
  • if it's not SVG, then we have a document fragment — we can just insert it as-is rather than inserting child nodes one at a time

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: b64f07c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 4a63168 into main Mar 30, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the optimise-html-tag branch March 30, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants