Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base stylesheet.id on CSS contents #1119

Merged
merged 4 commits into from
Jan 20, 2018
Merged

Base stylesheet.id on CSS contents #1119

merged 4 commits into from
Jan 20, 2018

Conversation

Rich-Harris
Copy link
Member

Follow-up to #1105 that causes CSS scoping to be based on styles alone, but also preserves the previous ast.hash behaviour. The mysterious test failure is still present.

@codecov-io
Copy link

codecov-io commented Jan 19, 2018

Codecov Report

Merging #1119 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1119   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         125      125           
  Lines        4518     4518           
  Branches     1457     1457           
=======================================
  Hits         4133     4133           
  Misses        163      163           
  Partials      222      222
Impacted Files Coverage Δ
src/parse/index.ts 88.04% <ø> (ø) ⬆️
src/utils/hash.ts 100% <ø> (ø)
src/css/Stylesheet.ts 89.9% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0be845...f61acd0. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 050ed5d into master Jan 20, 2018
@Rich-Harris Rich-Harris deleted the gh-1091 branch January 20, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants